Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for passing headers #57

Closed
chevinbrown opened this issue Nov 6, 2018 · 5 comments
Closed

support for passing headers #57

chevinbrown opened this issue Nov 6, 2018 · 5 comments

Comments

@chevinbrown
Copy link

There is currently no ability to pass headers--since bearer token/JWT is fairly common this makes using this library pretty difficult.

I'm going to fool around with merging this library into this one because it's a joy to use:

https://github.com/OlegIlyenko/graphiql-workspace

Would you be open to something like that, or at a minimum adding header support?

@chevinbrown
Copy link
Author

After playing with this for just a few minutes, the react project above has a lot of niceties that this project could benefit from.

How would you feel about wrapping that library?

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 6, 2018

Hi, I think it's be a great idea to have a Ruby-ready wrapper of that project! I think it would be possible to make an event better library, too, making a Rack app instead of a Rails engine, so that even non-Rails (and non-Sprockets) apps could use it. Let me know how it goes!

@rmosolgo rmosolgo closed this as completed Nov 6, 2018
@chevinbrown
Copy link
Author

@rmosolgo Do you think header-passing is out of scope for this library? Or are you too busy to propose this as a feature?

Or do you prefer no issues and PRs only?

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 6, 2018

It's probably out-of-scope. I mean, you're talking about accepting user input then sending that along with requests, right? So it would need a UI and glue code? My impression is that time would be better spent wrapping graphql-workspace, since it has so many other good features!

@chevinbrown
Copy link
Author

Correct--with this library, there's no way to pass a JWT/Bearer token as a header.

It's really sad about OSS...so little time and so much that the community needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants