fix duplicate method in G::A::A::QueryComplexity

with rubocop settings for it
rmosolgo · Feb 21, 2019 · 6372704 · 6372704
1 parent d5da369
commit 6372704
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -26,6 +26,9 @@ Layout/EndAlignment:
 Lint/UselessAssignment:
   Enabled: true
 
+Lint/DuplicateMethods:
+  Enabled: true
+
 Metrics/ParameterLists:
   Max: 7
   CountKeywordArgs: false

diff --git a/lib/graphql/analysis/ast/max_query_complexity.rb b/lib/graphql/analysis/ast/max_query_complexity.rb
@@ -9,7 +9,7 @@ class MaxQueryComplexity < QueryComplexity
         def result
           return if query.max_complexity.nil?
 
-          total_complexity = super
+          total_complexity = max_possible_complexity
 
           if total_complexity > query.max_complexity
             GraphQL::AnalysisError.new("Query has complexity of #{total_complexity}, which exceeds max complexity of #{query.max_complexity}")

diff --git a/lib/graphql/analysis/ast/query_complexity.rb b/lib/graphql/analysis/ast/query_complexity.rb
@@ -57,7 +57,8 @@ def on_leave_fragment_spread(node, _, visitor)
           visitor.leave_fragment_spread_inline(node)
         end
 
-        def result
+        # @return [Integer]
+        def max_possible_complexity
           @complexities_on_type.last.max_possible_complexity
         end