Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 #3729

Closed
23 of 25 tasks
rmosolgo opened this issue Nov 24, 2021 · 4 comments
Closed
23 of 25 tasks

Release 2.0 #3729

rmosolgo opened this issue Nov 24, 2021 · 4 comments
Milestone

Comments

@rmosolgo
Copy link
Owner

rmosolgo commented Nov 24, 2021

My only plans for 2.0 are to remove deprecated code:

  • Remove:
    • .define, old type classes, old field and argument classes, def to_graphql, Query::Arguments
    • Migration docs, any mentions of the Interpreter as an option or alternative
    • SerialExecution, GraphQL::Execution::Execute, Query::ArgumentsCache (because interpreter has a new one)
    • Old Relay helpers (connections, mutation, node Id)
    • Old execution extension points: field instrumentation, middleware
    • Irep & irep analysis
    • GraphQL::Compatibility -- no external runtimes are supported, no external parsers are supported (libgraphqlparser-ruby hasn't worked since 1.9.x)
    • Rework execution to bypass executor?
    • Schema::Validation
    • Schema::Upgrader, Railtie
    • Schema instance behaviors (associated with .define-returned instances)
    • GraphQL::Function
    • GraphQL::BackwardsCompatibility (which was for .define)
    • GraphQL::DeprecatedDSL
    • Legacy validator classes with .validate
    • SCREAMING_CASE scalar type constants
    • Multiplex#run_one_legacy etc
    • GraphQL::Deprecate
    • Remove SkylightTracing which has been deprecated for some time
    • There should be no checks for .interpreter? and that method should always return true -- same for .using_ast_analysis?
    • Deprecate .interpreter? and .using_ast_analysis? -- no, leave them in case libraries or applications are using them for feature detection. They can be removed later.
    • Remove warnings about new defaults (Interpreter, connections, ast analysis, subscription setup
    • more? Search for warn, etc
  • Move Analysis::AST to Analysis, but re-assign it to Analysis::AST for compatibility push this off to 2.1 or so
  • Remove TESTING_INTERPRETER, legacy CI build
  • Add code coverage, assess other untested code Add code coverage #3806
  • Add some profiles to source control, to monitor performance Add code coverage #3806
@rmosolgo
Copy link
Owner Author

😗 👌

image

@joelzwarrington
Copy link
Contributor

😗 👌

image

👨‍🍳 💋

@rmosolgo
Copy link
Owner Author

rmosolgo commented Feb 9, 2022

💥 https://rubygems.org/gems/graphql/versions/2.0.0 🚢

@rmosolgo rmosolgo closed this as completed Feb 9, 2022
@rmosolgo
Copy link
Owner Author

rmosolgo commented Feb 9, 2022

I didn't accomplish my goal on the workflow improvements :( I got code coverage set up, and I used it to find and destroy legacy code, but I didn't get a good project workflow in place. I'm hoping to keep up with that in #3880, using gh-actions and artifacts. Then, hopefully I'll find a better workflow for benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants