Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try reducing stack trace size during queries #3957

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Feb 22, 2022

TODO:

  • Gather some before benchmarks on memory consumed during runtime (not just limits, but also how much is GC'ed) and stack trace size at certain points
  • See if this improves either measure
  • The real work is in runtime.rb -- reducing recursive calls and nesting.

@rmosolgo
Copy link
Owner Author

rmosolgo commented Mar 1, 2022

New benchmark shows:

Result         Depth
---------------------
Eager          196
Lazy           74
Very Lazy      45

@rmosolgo rmosolgo added this to the 2.0.3 milestone Mar 1, 2022
@rmosolgo rmosolgo merged commit db7c89e into master Mar 1, 2022
@rmosolgo rmosolgo deleted the inline-errors branch March 1, 2022 20:06
@rmosolgo
Copy link
Owner Author

For reference, the "before" profile is here: #3968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant