Remove branch that uses code removed in 2.0 #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseConnection was removed in 2.0 so that branch throws an error. Context is now required
rmosolgo
reviewed
Mar 9, 2022
lib/graphql/relay/range_add.rb
Outdated
Comment on lines
38
to
40
| unless context.schema.new_connections? | ||
| raise ArgumentError, "No connections are defined for context.schema" | ||
| end |
There was a problem hiding this comment.
I think this could only happen if someone set self.connections = nil in their schema definition. IMO we don't have to handle that case nicely (I've never seen it before), do you think it'd be ok to remove this? Or does it handle another situation I haven't thought of?
There was a problem hiding this comment.
I'm not sure about this case, I didn't want to remove the check that already existed! I'll remove it
I don't believe it was. For context we updated to 2.0.2 and this broke: GraphQL::Relay::RangeAdd.new(
collection: job.job_hidden_stage_links,
item: link,
).edgeadding the context fixed it |
|
Thanks again for this fix -- I opened an issue to track that deprecation in 1.13.x 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseConnection was removed in 2.0 so that branch throws an error. Context is now required