Allow multiples of repeatable directives #3986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's up
When adding directives to an object, we currently overwrite any existing directives of the same class. However, if the directive is repeatable, we should be able to specify multiple directives without overwriting existing ones.
Solution
Pretty simple: Don't remove existing directives if the directive in question is repeatable.
Caveats
I haven't explicitly checked the printer to make sure it does the right thing when printing multiple of the same directives. I assume it isn't really any different than if the object had multiple different directives.