-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query execution context based tracing for API requests #4077
Add query execution context based tracing for API requests #4077
Conversation
Awesome, thanks for sharing this improvement! Yep, I'll backport it to 1.13.x and release a new version there shortly. |
🚢 in 1.13.13 ! |
Thanks a lot, much appreciated :) |
🤔 Do you want to maintain It was originally included here to demonstrate how everything works together across gems. |
Either way works for me 🤷 |
I realize you just shipped a release, but I was unsure if we verified/documented how it integrates with I'm not sure if/how copyright plays a role in this decision either, we basically forked the original. IMO we remove |
First-party OpenTelemetry instrumentation is a wonderful thing. We very much want to encourage this. It really should not depend on the OpenTelemetry Ruby auto-instrumentation in any way, though. The goal should be to deprecate the OpenTelemetry auto-instrumentation in favour of first-party instrumentation. There should be no reference to I'll look at the licensing issues, but speaking for myself, I have no problem with copying any of the instrumentation code from the OpenTelemetry Ruby GraphQL auto-instrumentation into this repo, with or without attribution. |
Closes #4001
An attempt at allowing tracing per request as per suggestions in #4001
cached_platform_key
now accepts the trace phase as a third parameter.OpenTelemetryTracing
overridescached_platform_key
to access execution context not available inplatform_field_key
,platform_authorized_key
,platform_resolve_type_key
This PR includes
PlatformTracing
CI has failed due to rubocop failures in files not associated with this PR.If this looks good, we are hoping to add this to 1.13.x (< 2) since we haven't yet migrated.