Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attr_reader :options for TypeMembership #4209

Merged

Conversation

mpospelov
Copy link
Contributor

In order to filter-out interfaces-type membership during ApolloFederation dumping the access to TypeMembership#options is opened.

The use case is the following:

  1. We have schema like
class Foobar < BaseType
  implements FooInterface
end
  1. In order to drop it in 0 downtime fashion we need to mark this implements
class Foobar < BaseType
  implements FooInterface, apollo_federation: false
end
  1. So in order to access this apollo_federation key value we need to open access to TypeMembership#options instance variable

@rmosolgo rmosolgo added this to the 2.0.15 milestone Sep 26, 2022
@rmosolgo
Copy link
Owner

Thanks for the improvement here!

@rmosolgo rmosolgo merged commit aaa48fa into rmosolgo:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants