Pass and merge subscription's event and query ctxs #4242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subscription is triggered, there's an param to pass a
context:
but it's lost because it's not forwarded to theSubscription::Event
.Now when
Subscription#execute_update
is executed, we can now merge query's context with event's context.This allows to pass an id of the sender of a query and compare it with the receiver of a subscription in the
#update
method, for example to prevent the sender of the subscription to receive its own updates by skipping it when the ids match.Example: