Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support update-and-unsubscribe flow #4283

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Support update-and-unsubscribe flow #4283

merged 7 commits into from
Aug 28, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Jan 2, 2023 •
edited

Fixes #4279

TODO:

  • This implementation is really unsustainable -- although I've implemented it in one test, I don't think it'll work in ActionCable or other implementations yet. Very clunky.
  • Make sure it works with ActionCable, Pusher, and Ably
  • Double-check implementations to make sure they're sending more: false correctly. Maybe that's a better implementation: unsubscribe sets that flag but doesn't halt execution at all...

@rmosolgo rmosolgo added this to the 2.1 milestone Apr 7, 2023
@rmosolgo rmosolgo changed the base branch from master to 2.1-dev July 25, 2023 17:40
@rmosolgo rmosolgo merged commit 076c75a into 2.1-dev Aug 28, 2023
13 checks passed
@rmosolgo rmosolgo deleted the unsubscribe-and-update branch August 28, 2023 14:51
@rmosolgo rmosolgo mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

unsubscribe should support update-and-unsubscribe flow
1 participant
@rmosolgo