-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tracing::Trace for method-based tracing #4344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2023
jazairi
added a commit
to MITLibraries/timdex
that referenced
this pull request
Mar 20, 2023
Why these changes are being introduced: The tracer API was overhauled in v2.0.18 of GraphQL for performance reasons. Custom tracers are now defined as modules instead of classes, and hooks are mixed in using `Schema.trace_with`. The old way of defining custom tracers is still allowed by adding `trace_class(GraphQL::Tracing::LegacyTrace)` to the schema. See rmosolgo/graphql-ruby#4344 for more info on this change. Relevant ticket(s): N/A. How this addresses that need: This updates graphql-ruby to the latest version and specifies the legacy tracer API in the schema. Side effects of this change: We should update our tracer to use the new API. I opened a ticket to that effect: https://mitlibraries.atlassian.net/browse/ENGX-221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4313
When tracing only
Hash
es:Remaining Hash allocations after this change, just FYI
TODO:
tracer_module(...)
?How to keep options separate between modules?puntDecide if/how to handlepuntbacktrace: true
shopify/graphql-metrics