Ensure correct hasNextPage Value When Relation is Already Loaded #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the overridden ActiveRecordRelationConnection#relation_larger_than method. The overridden method was flawed as demonstrated by the test case. The parent class implementation appears to return the correct result.
calebpowell
commented
Feb 17, 2023
| @@ -93,10 +101,9 @@ def get_last_cursor(result) | |||
| assert_equal(true, conn["pageInfo"]["hasNextPage"]) | |||
|
|
|||
| log_entries = log.split("\n") | |||
| assert_equal 2, log_entries.size, "It ran 2 sql queries" | |||
| assert_equal 1, log_entries.size, "It should run 1 sql query" | |||
There was a problem hiding this comment.
The change seems to remove the need for the following query:
SELECT 1 AS one FROM bases WHERE bases.id IN (SELECT bases.id FROM bases WHERE bases.faction_id = ?) LIMIT ? OFFSET ?\e[0m [[faction_id, 2], [LIMIT, 1], [OFFSET, 2]
rmosolgo
reviewed
Feb 20, 2023
spec/integration/rails/graphql/relay/relation_connection_spec.rb
Outdated
Show resolved
Hide resolved
rmosolgo
reviewed
Feb 20, 2023
spec/integration/rails/graphql/relay/relation_connection_spec.rb
Outdated
Show resolved
Hide resolved
|
Thanks for this improvement! I think this spec was basically added to document the behavior at the time, so an improvement is very welcome 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the overridden
ActiveRecordRelationConnection#relation_larger_thanmethod. The overridden method was flawed as demonstrated by the test case on this PR and the parent class implementation appears to return the correct result.Note that some of the timing related tests are failing for me (but some of them fail on
masteras well?). It may be that my change introduces additional queries since the some of the prior work done in this area was to address performance. That said, correctness comes first. There is probably a better fix for this issue but I am unfamiliar with the code base 馃槄. Please let me know if this commit would introduce additional issues.See Issue #4337