New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for histograms to prometheus_tracing #4418

Merged

rmosolgo merged 1 commit into rmosolgo:master from b1zzu:prometheus-histogram

Apr 8, 2023

Contributor

b1zzu commented Apr 3, 2023

The prometheus_exporter supports histograms if enabled, but the GraphQLCollector collector always uses summary.

See: https://github.com/discourse/prometheus_exporter#histogram-mode

Similar to the WebCollector this PR use the PrometheusExporter::Metric::Base.default_aggregation instead of the hardcoded Summary metrics


          Add support for histograms to prometheus_tracing

c5d8608

rmosolgo added this to the 2.0.21 milestone

Owner

rmosolgo commented Apr 8, 2023

Thanks for this improvement!

rmosolgo merged commit 9c574fc into rmosolgo:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment