Fix tracer compatibility with inheritance #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using a legacy
tracer ...would silently attach a newtrace_classcalledLegacyTracewhose only job was to call legacy tracers. However, if the parent class has new-styletrace_withmodules attached,LegacyTracewouldn't call them because those modules weren't inLegacyTrace's inheritace.This branch takes the behavior of calling legacy tracers and puts it in a module instead, so that it can be added to an intact inheritance chain when it's needed, without disrupting
trace_withsetups from the parent class. (The oldLegacyTraceclass is left in place for compatibility, but error messages point to this new module now.)Fixes #4486