Add Source#result_key_for #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgwizard
approved these changes
Jul 27, 2023
|
|
||
| ## De-duplicating equivalent objects | ||
|
|
||
| Sometimes, _different_ objects in the application should load the same object from `fetch`. You can customize this behavior by implementing `def result_key_for(key)` in your application. For example, to map records from your ORM to their database ID: |
There was a problem hiding this comment.
The use-case I have is actually the opposite - two Active Record objects that point to the same DB row both hash and eql? the same, but for my loader (a version of an AssociationLoader) needs to see all the records in fetch, without the deduping that happens when Active Record objects are used as keys in hashes/sets.
There was a problem hiding this comment.
Got it -- I updated the doc to mention this case, as well. Thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to deduplicate
.load(...)calls when the passed-in object is equivalent but doesn't implement.hashto the same value.