Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check an object's abstract type's referenced or orphan_type status for visibility #4589

Merged
merged 12 commits into from
Oct 10, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Aug 18, 2023

Fixes #4587

I hope ...

The challenge is, on the one hand:

  • We need some way to add types to the schema to be used for loads:
  • On the other hand, we have existing tests that say that orphan_types [...] isn't enough to make objects appear in results.

I think we'll need to track loads: references specifically 😩

@rmosolgo rmosolgo force-pushed the fix-type-with-interface-visibility branch from f80fe9b to ab6a979 Compare August 18, 2023 20:00
@rmosolgo rmosolgo removed this from the 2.0.27 milestone Aug 30, 2023
@rmosolgo rmosolgo added this to the 2.1.2 milestone Oct 10, 2023
@rmosolgo rmosolgo merged commit f11fdda into master Oct 10, 2023
12 checks passed
@rmosolgo rmosolgo deleted the fix-type-with-interface-visibility branch October 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphan types are exposed when using interfaces
2 participants