(fix) Enum_Value Directive missing from Schema IDL #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t illustrates the issue of an `ENUM_VALUE` adjacent custom-directive not being included in the dumped IDL output. Only able to make it work by explicitly attaching the custom-directive to the `GraphQL::Schema` implementation directly. Going to investigate if this is something in the `GraphQL::Language` or perhaps in `GraphQL::Schema` itself.
…m` traversal on the `EnumValue` child nodes when the current node being evaluated is an `Enum`. Resolves the behavior described in rmosolgo#4594
rmosolgo
reviewed
Aug 28, 2023
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug-fix for #4594 and has been validated using the spec scenario created for triaging the initial issue.
Summary: Enum_Value nodes were not being traversed in the
GraphQL::Schema:AdditionAST-walk, resulting in any ENUM_VALUE targeted Directives not being added to the Schema IDL during document generation. This would produced incomplete IDL output that breaks downstream validators and codegenerators.