AsyncDataloader: only run Sources async #4757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By limiting the source loop to use the
async
gem, I limit the "Fiber mayhem" that has led to so many bugs. The source loop is tight; sources only wait for other sources, so it never re-enters GraphQL execution. It doesn't have arbitrarydataloader.run
depth like GraphQL execution does.But, it means that I/O in plain resolvers won't be run async.