Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid sending an equipped NFT #187

Closed
mrshiposha opened this issue Jun 21, 2022 · 4 comments · Fixed by #189
Closed

Forbid sending an equipped NFT #187

mrshiposha opened this issue Jun 21, 2022 · 4 comments · Fixed by #189

Comments

@mrshiposha
Copy link
Contributor

I suggest forbidding sending of an equipped NFT. I believe sending an equipped NFT can lead to exploits like #185...
Also, I think that it is logically more accurate to unequip an equipped NFT first and then send it to some user/token.

@ilionic
Copy link
Contributor

ilionic commented Jun 22, 2022

@mrshiposha thanks for the reporting. In Kusama rmrk-tools version we unequip during sending. Ideally to have feature parity, so will look into that.

@bmacer
Copy link
Contributor

bmacer commented Jun 23, 2022

I think forbidding SEND would be difficult as send is part of rmrk-core, but equip (and the Equippings storage) is part of rmrk-equip...and unequipping during SEND would be difficult for the same reason...

@mrshiposha
Copy link
Contributor Author

But there is an equipped flag inside the NftInfo (which is a part of RMRK core). Maybe it could be used to prevent sending of an equipped NFT?

@bmacer
Copy link
Contributor

bmacer commented Jun 25, 2022

indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants