Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A sort of sections on page refresh #108

Closed
Jrizzi1 opened this issue May 8, 2015 · 9 comments
Closed

A sort of sections on page refresh #108

Jrizzi1 opened this issue May 8, 2015 · 9 comments

Comments

@Jrizzi1
Copy link

Jrizzi1 commented May 8, 2015

every time i refresh, i have to find my section again that i was working on, which is sometimes not an easy feat...maybe a sort applied to the sections of testing?

@ashleygwilliams
Copy link
Collaborator

hi @Jrizzi1 ! this is a duplicate of #61 - the tests are in a random order because they are loaded using require.

a few weeks ago we decided to close the issue- but we are currently working on some rewrites as we move to a major version release, and i think that this is at least worth reconsidering. i can empathize with getting disoriented!

@jmeas @kadamwhite thoughts?

@ashleygwilliams
Copy link
Collaborator

OH ALSO: thank you so much for contributing an issue, @Jrizzi1 👍

@jamesplease
Copy link
Collaborator

I'm thinking we could potentially just get rid of require altogether. What we would do instead is just type out the filenames manually in the test file and use browser globals.

Loading each script manually is old-school, and using globals is bad practice, but in this case these things work really well, I think. Because of the fact the app files are stubbed out, nobody will need to go in and add new script tags when they clone this lib to write some code. Also, the browser globals will already be added by us in those stubs.

The only time someone would need to change either of these is if they planned to add new tests, and an instruction on how to do that would be easy to add to the README, I think.

What we get in exchange for those two inconveniences are:

  1. assurance that the tests load in the same order, always
  2. removal of nasty AMD wrapper code in every file
  3. removal of the require config file

Thoughtz?

@ashleygwilliams
Copy link
Collaborator

yeah i am so into this

@jamesplease
Copy link
Collaborator

I can try to put together a PR tonight!

@ashleygwilliams
Copy link
Collaborator

cool. i'mma ship the new browser deps stuff soon, so there shouldn't be a conflict.

@ashleygwilliams
Copy link
Collaborator

yo @jmeas - did you get to this yet? if not i might try to tackle it tonight cuz it's blocking

@jacobroufa
Copy link

This should be fixed by #112. 👍

@ashleygwilliams
Copy link
Collaborator

solved with #112, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants