Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light up sample/note names as they are triggered #10

Closed
ViktorNova opened this issue Mar 17, 2017 · 7 comments
Closed

Light up sample/note names as they are triggered #10

ViktorNova opened this issue Mar 17, 2017 · 7 comments

Comments

@ViktorNova
Copy link

This would be AWESOME and super helpful, if the sample name/number/note name lit up in the list on the right as they are being triggered by MIDI.

In a large sample library, it is sometimes difficult to pin down what sample is responsible for a sound being triggered without a visual cue, and it's not always easy to go to the sequencer to hunt it down. This would help a lot (and would also look cool!)

A flash of highlight behind the text that was proportionate to the current output volume of the sample being played would be even cooler, but not necessary!

@rncbc
Copy link
Owner

rncbc commented Mar 17, 2017

@ViktorNova : something resembling a MIDI In LED on each key element is still in the plans.

@ViktorNova
Copy link
Author

Awesome!! That is great to hear =)

@rncbc
Copy link
Owner

rncbc commented Mar 28, 2017

@ViktorNova : checkout midi_in_led branch from the latest git head ;)

@rncbc
Copy link
Owner

rncbc commented Mar 30, 2017

@ViktorNova : now merged to git head master:
651539e

relevant change-log line:

  • A MIDI In(put) status fake-LED is now featured on the
    bottom-left status bar, adding up to eye-candy as usual;
    also, each drum element key/sample now have their own
    fake-LED flashing on respective MIDI note-on/off events.

hth.
cheers

@ViktorNova
Copy link
Author

WOW this is a game changer!!! Thank you.

Might I suggest a slight improvement - adding a small amount of fade out time to the LED when the note-off is received, rather than switching the LED off immediately? It would make it a little easier to spot what notes are being triggered

@rncbc
Copy link
Owner

rncbc commented Mar 31, 2017

@ViktorNova : done:
-Timeout added to drum element note/key status LEDs turning off. de288af

@ViktorNova
Copy link
Author

Very cool. This is huge, thanks so much for taking input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants