-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking even when looping between zero crossings #12
Comments
yes, probably it's a more like a feature turned into a bug :) fact is that samplv1 searches for its own zero-crossings too, on its own at the loop start/end points. however, it also applies a forced micro-fade-in and -out at the loop-start and -end resp. over a fixed number of frames (32 samples) independently of current sample-rate. it is this micro-fade-in/out that you see as anomalies on the waveform graphics above. i'll see whether this micro-fade-io-sh*tty-artifacts may be axed tout-couer as it nowadays seems like just an overzealous and naive design and engineering mistake. ;) cheers && thanks |
good news are micro-fade-in/outs on loop points are now gone ( c226562 ) |
Thank you, Rui, for the fast response! I cannot test it right now, but your choice seems excellent. Easy loops should loop easily, I guess. I will test it as soon as possible. In case you have already tried the attached or a similar sample and found it fine, you could close the current issue. If not, I will do so after testing it. Keep on rocking in the free and open-source world! |
Clicking is gone. Closing. Thank you! |
Greetings, Rui and lurkers!
Investigating
samplv1
, I am not able to produce a click-less looping sound, based on a simple sample. I created the sample usingqtractor
and a simpleamsynth
patch. Usingaudacity
I selected a nice regionat zero crossings
, which I believed should yield a click-less sound when looping over (please tell me in case I have totally misunderstood something, since I have just started playing with sampling). I then loaded the sample tosamplv1
, using the at-zero-crossings sample numbers asstart
andend
, and recorded a single note usingqtractor
. I finally exported the audio. The input sample and exported audio are here: sample-and-export.zip. Clicks are audible in the exported audio.This is the waveform of the input sample and the selected at-zero-crossings region (I selected ten periods):
This is the configuration of
samplv1
:These are parts of the exported audio (normalized). I have marked what I believe are anomalies:
Is there an error on my part or is this a bug?
The text was updated successfully, but these errors were encountered: