Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch as phase vocoder #14

Closed
m4l3z opened this issue Mar 18, 2018 · 4 comments
Closed

Pitch as phase vocoder #14

m4l3z opened this issue Mar 18, 2018 · 4 comments

Comments

@m4l3z
Copy link

m4l3z commented Mar 18, 2018

Hey Rui, hope you're doing fine,

I was wondering about the possibility to add a second algorithm (or replace the current implementation) for pitch shifting that would use a phase vocoder instead of playback rate. I heard of soundtouch LGPL and rubberband GPL The user would have the possibility to choose what the midi notes will modify between :

  • speed
  • pitch
  • playback rate (speed & pitch)
    The main goal is to be able to preserve the bpm of the rhythmic elements in the samples but I think this could lead to a lot of happy accidents/experimentation too.
    Tell me what you think about that idea and how realistic it is,

Take care,

@rncbc
Copy link
Owner

rncbc commented Mar 18, 2018

believe me, it all has been thought and tried before, to split sample wavetables over higher and lower octaves at least, using soundtouch, rubberband and quite a few others, even a homebrew PSOLA , with mixed and disparate results; quite frankly most of the results were all far from just good enough, so it was all just ditched for a while.

@m4l3z
Copy link
Author

m4l3z commented Mar 18, 2018

Alright, if none of these approaches made viable results I understand the frustration, I naively didn't expect the two mentioned libs to be so problematic to use.
Thanks for the quick feedback !

@rncbc
Copy link
Owner

rncbc commented Mar 18, 2018

they are not problematic, they work fine but some samples sounds work better with some and bad with with others and vice-versa.

anyway, i'll try to revisit all this in the future--the subject is not ditched for good ;)
thanks

@rncbc
Copy link
Owner

rncbc commented Sep 3, 2020

there are news over here :)
check this out: samplv1 >= 0.9.16.32git.66aeb5
cheers

@rncbc rncbc closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants