pull from master #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses argparse(https://github.com/mpeterv/argparse) to handle commands and parameters
…t show the list of commands available
Having special cases for servers inside Sailor isn't optimal. This should go inside Remy.
Add support for cookies when using Sailor with Lwan
… xspager-cli_refactor
I was using camelCase for table keys, changed them to snake_case.
Added relevant documentation in English for the new CORS feature.
Added two very naive tests for the new CORS feature. They only assert that `page:enable_cors()` is able to run without errors, they don't actually check the output headers (needs improvement).
Argh! Missing commas in the refactored code.
Fixing bug with accessing the wrong variable.
Minor English improvements
Need to double check if the passed data is nil.
feat(cors): Add support for Cross Origin Requests
feat(cli): Add autogen to cli
feat(cli): Add start server command to Sailor command line client
Don't call `require "start-server"` in unprotected mode, actually pass `require` and `"start-server"` as arguments to `pcall`. Use `pcall` instead of `xpcall` as no error handler is used.
fix(cli): Fix missing start-server.lua handling in start command
fix(page): Don't pollute _G with parameters when rendering a page
Add missing `local` declarations in sailor.cli.test(). Also move `require "lfs"` from sailor script to sailor.cli so that it doesn't rely on lfs setting itself as a global (it won't in 2.0).
fix(cli): Fix some globals in sailor.cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.