New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with new v7.0.0 features #88
Comments
This isn't a new 7.x thing, but I noticed today that telemetry methods added in nitaliano/react-native-mapbox-gl#1096 aren't documented. There are:
Started to open a PR, but I wasn't sure the best place to put them since they're not on a component, but the base object. Happy to add them in a PR if someone can point me to the best place to put 'em |
FYI, think isTelemetryEnabled is no longer available in the native side. I
may be wrong, so please double check.
Update: Confirming `isTelemetryEnabled` is removed from Android. I've removed all traces of the code on our end is gone as well. Docs for `setTelemetryEnabled` is more than welcome.
…On Thu, 6 Jun 2019 at 18:50, Tyler Gaw ***@***.***> wrote:
This isn't a new 7.x thing, but I noticed today that telemetry methods
added in nitaliano/react-native-mapbox-gl#1096
<nitaliano/react-native-mapbox-gl#1096> aren't
documented.
There are:
- MapboxGL.isTelemetryEnabled = () => Promise<boolean>
- MapboxGL.setTelemetryEnabled = (enabled: Boolean) => void
Started to open a PR, but I wasn't sure the best place to put them since
they're not on a component, but the base object.
Happy to add them in a PR if someone can point me to the best place to put
'em
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/react-native-mapbox-gl/maps/issues/88?email_source=notifications&email_token=ABLAPWYP3DO2Z6RD55W6I6TPZE56LA5CNFSM4HUCBPOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDPHYA#issuecomment-499577824>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLAPWY6QAAUMRCLXEFZZYTPZE56LANCNFSM4HUCBPOA>
.
|
<Mapbox.Images images={[]}> |
Thanks for clarification @AbdullahADhaim we will wait for @EricPKerr 's answer |
@luisfuertes |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It worked for me removing styleUrl too. Close it please |
Couple new things in
v7.0.0
that aren't documented yet:The text was updated successfully, but these errors were encountered: