Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with new v7.0.0 features #88

Closed
EricPKerr opened this issue Jun 5, 2019 · 9 comments
Closed

Update documentation with new v7.0.0 features #88

EricPKerr opened this issue Jun 5, 2019 · 9 comments

Comments

@EricPKerr
Copy link
Contributor

EricPKerr commented Jun 5, 2019

@tylergaw
Copy link
Contributor

tylergaw commented Jun 6, 2019

This isn't a new 7.x thing, but I noticed today that telemetry methods added in nitaliano/react-native-mapbox-gl#1096 aren't documented.

There are:

  • MapboxGL.isTelemetryEnabled = () => Promise<boolean>
  • MapboxGL.setTelemetryEnabled = (enabled: Boolean) => void

Started to open a PR, but I wasn't sure the best place to put them since they're not on a component, but the base object.

Happy to add them in a PR if someone can point me to the best place to put 'em

@kristfal
Copy link
Member

kristfal commented Jun 6, 2019 via email

@karlguillotte
Copy link
Contributor

karlguillotte commented Jun 27, 2019

<Mapbox.Images images={[]}>

@luisfuertes
Copy link

I have an offline map downloaded. Does anyone know how I can load it? I get it with the "getPack" but it will not be added to the MapView.

const offlinePack = await MapboxGL.offlineManager.getPack(OFFLINE_ZONE_NAME)
Captura de pantalla 2019-07-08 a las 12 18 50

I'm sorry if this should go on stackoverflow but I do not know if the API is specific to this component.

Thanks!

@AbdullahADhaim
Copy link

I have an offline map downloaded. Does anyone know how I can load it? I get it with the "getPack" but it will not be added to the MapView.

const offlinePack = await MapboxGL.offlineManager.getPack(OFFLINE_ZONE_NAME)
Captura de pantalla 2019-07-08 a las 12 18 50

I'm sorry if this should go on stackoverflow but I do not know if the API is specific to this component.

Thanks!

I'm also curious how to load the offline pack in the MapView, I have my pack downloaded 100% but the mapview turns black when I'm in offline mode.
PS: in the deprecated version of RNMapBox it should work automatically when you're offline but doesn't seem to work in this verison.

@luisfuertes
Copy link

Thanks for clarification @AbdullahADhaim

we will wait for @EricPKerr 's answer

@AbdullahADhaim
Copy link

@luisfuertes
Finally it worked for me,currently maps is automatically working in offline mode, I was using a corrupted custom styleUrl and that's why the offline map wasn't working. I used MapBox's styleUrl and it's working now.

@stale
Copy link

stale bot commented Sep 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 9, 2019
@luisfuertes
Copy link

luisfuertes commented Sep 9, 2019

It worked for me removing styleUrl too. Close it please

@stale stale bot removed the wontfix This will not be worked on label Sep 9, 2019
@kristfal kristfal closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants