forked from sevntu-checkstyle/sevntu.checkstyle
-
Notifications
You must be signed in to change notification settings - Fork 0
/
AvoidModifiersForTypesCheckTest.java
393 lines (340 loc) · 19.3 KB
/
AvoidModifiersForTypesCheckTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2017 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////
package com.github.sevntu.checkstyle.checks.coding;
import static com.github.sevntu.checkstyle.checks.coding.AvoidModifiersForTypesCheck.MSG_KEY;
import static org.junit.Assert.fail;
import org.junit.Assert;
import org.junit.Test;
import com.github.sevntu.checkstyle.BaseCheckTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
/**
* <p>
* @author <a href="mailto:Daniil.Yaroslavtsev@gmail.com"> Daniil Yaroslavtsev</a>
* @author <a href="mailto:yasser.aziza@gmail.com">Yasser Aziza</a>
* </p>
*/
public class AvoidModifiersForTypesCheckTest extends BaseCheckTestSupport {
private final DefaultConfiguration checkConfig =
createCheckConfig(AvoidModifiersForTypesCheck.class);
@Test
public void testFinal() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = "InputAvoidModifiersForTypesCheck";
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String publicRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = null;
final String privateRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
final String[] expected = {
"19:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"20:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"24:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"29:9: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testPackagePrivate() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = "InputAvoidModifiersForTypesCheck";
final String protectedRegexp = null;
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"23:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck",
"package-private"),
"24:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck",
"package-private"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testAnnotationPrivateStatic() throws Exception {
final String annotationRegexp = "File";
final String finalRegexp = null;
final String staticRegexp = "File";
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = "File";
final String packagePrivateRegexp = null;
final String protectedRegexp = null;
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"18:5: " + getCheckMessage(MSG_KEY, "File", "annotation"),
"18:5: " + getCheckMessage(MSG_KEY, "File", "private"),
"18:5: " + getCheckMessage(MSG_KEY, "File", "static"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testProtectedAndTransient() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = "InputAvoidModifiersForTypesCheck";
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = "InputAvoidModifiersForTypesCheck";
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"21:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "protected"),
"21:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "transient"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testPublicAndVolatile() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = "InputAvoidModifiersForTypesCheck";
final String privateRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = null;
final String publicRegexp = "InputAvoidModifiersForTypesCheck";
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"22:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "public"),
"22:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "volatile"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testFinalAndPrivatePackage() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = "InputAvoidModifiersForTypesCheck";
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = "InputAvoidModifiersForTypesCheck";
final String protectedRegexp = null;
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"19:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"20:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"23:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck",
"package-private"),
"24:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"24:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck",
"package-private"),
"29:9: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testFinalAndStatic() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = "InputAvoidModifiersForTypesCheck";
final String staticRegexp = "InputAvoidModifiersForTypesCheck";
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = null;
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"19:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"20:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"20:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "static"),
"24:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
"29:9: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "final"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testProtected() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = "InputAvoidModifiersForTypesCheck";
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"21:5: " + getCheckMessage(MSG_KEY, "InputAvoidModifiersForTypesCheck", "protected"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testLogger() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = "Logger";
final String protectedRegexp = "Logger";
final String publicRegexp = "Logger";
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {
"36:9: " + getCheckMessage(MSG_KEY, "Logger", "protected"),
"37:9: " + getCheckMessage(MSG_KEY, "Logger", "public"),
"38:9: " + getCheckMessage(MSG_KEY, "Logger", "package-private"),
};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck.java"), expected);
}
@Test
public void testAnyFile() throws Exception {
final String annotationRegexp = null;
final String finalRegexp = null;
final String staticRegexp = null;
final String transientRegexp = null;
final String volatileRegexp = null;
final String privateRegexp = null;
final String packagePrivateRegexp = null;
final String protectedRegexp = null;
final String publicRegexp = null;
checkConfig.addAttribute("forbiddenClassesRegexpAnnotation", annotationRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpFinal", finalRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpStatic", staticRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpTransient", transientRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpVolatile", volatileRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPrivate", privateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPackagePrivate", packagePrivateRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpProtected", protectedRegexp);
checkConfig.addAttribute("forbiddenClassesRegexpPublic", publicRegexp);
final String[] expected = {};
verify(checkConfig, getPath("InputAvoidModifiersForTypesCheck2.java"), expected);
}
/**
* This test is needed in order to test the Invalid Token case which is not reproducible with
* compilable sources and correctly worked parser.
*/
@Test
public void testUnsupportedModifier() {
final DetailAST sync = new DetailAST();
sync.setType(TokenTypes.LITERAL_SYNCHRONIZED);
final DetailAST ident = new DetailAST();
ident.setType(TokenTypes.IDENT);
ident.setText("dummy");
final DetailAST type = new DetailAST();
type.setType(TokenTypes.TYPE);
type.addChild(ident);
final DetailAST child = new DetailAST();
child.setType(TokenTypes.MODIFIERS);
child.addChild(sync);
final DetailAST node = new DetailAST();
node.addChild(type);
node.addChild(child);
final DetailAST parent = new DetailAST();
parent.setType(TokenTypes.OBJBLOCK);
parent.addChild(node);
final AvoidModifiersForTypesCheck check = new AvoidModifiersForTypesCheck();
try {
check.visitToken(node);
fail();
}
catch (IllegalArgumentException ex) {
Assert.assertEquals("Found unsupported token: LITERAL_SYNCHRONIZED", ex.getMessage());
}
}
}