Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused property warning in React 15.2.0 #33

Closed
HadrienPierart opened this issue Jul 8, 2016 · 7 comments
Closed

Unused property warning in React 15.2.0 #33

HadrienPierart opened this issue Jul 8, 2016 · 7 comments

Comments

@HadrienPierart
Copy link

HadrienPierart commented Jul 8, 2016

With React 15.2.0, any unrecognized props assigned to DOM elements will throw a warning. In the case of this library, the following warning occurs:

Warning: 
Unknown props `aspectRatio`, `guides`, `zoomable`, `crop`, `build`, `built`, `dragMode`, `scaleX`, `scaleY`, `enable`, `zoomTo`, `rotateTo` on <div> tag. 
Remove these props from the element.
For details, see https://fb.me/react-unknown-prop
    in div (created by ReactCropper)
@HadrienPierart
Copy link
Author

You can check over here for an interesting discussion on how to fix this warning :
Hacker0x01/react-datepicker#517

@HadrienPierart
Copy link
Author

Do you want me to propose a PR following what was chosen in the discussion if you dont have the time to implement this yourself ?

@dingdada
Copy link

dingdada commented Aug 6, 2016

I have the same problem, I hope you can fix it.

@gentgaashi
Copy link

Yep same here, just wanted to ask if there is any chance of fixing this in the near future.

@roadmanfong
Copy link
Collaborator

Kind of busy recently.
Any pull request is welcome.

@alexdong
Copy link
Contributor

@roadmanfong Just submitted a PR for this. Would love to hear your comments on the package.json changes.

@roadmanfong
Copy link
Collaborator

@alexdong, thank you for your contribution.
I also update eslint to 3.3.1, and modified some code let the code to meet the rule of new eslint-airbnb-config.
I Just publish 0.9.1 Please let me know if it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants