New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SSR compatible by loading cropperjs lazily #54

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
2 participants
@gfx
Contributor

gfx commented Dec 2, 2016

cropperjs is not server-side rendering compatible.

With this PR cropperjs is loaded lazily so it should be SSR safe.

@gfx gfx changed the title from make SSR compatible to load cropperjs lazily to make SSR compatible by loading cropperjs lazily Dec 2, 2016

@roadmanfong roadmanfong merged commit cb02aaa into roadmanfong:master Dec 2, 2016

@gfx gfx deleted the gfx:ssr branch Dec 3, 2016

@gfx

This comment has been minimized.

Show comment
Hide comment
@gfx

gfx Dec 3, 2016

Contributor

Thanks. v0.10.0 works on my SSR app.

Contributor

gfx commented Dec 3, 2016

Thanks. v0.10.0 works on my SSR app.

@roadmanfong

This comment has been minimized.

Show comment
Hide comment
@roadmanfong

roadmanfong Dec 3, 2016

Owner
Owner

roadmanfong commented Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment