[🐛 BUG]: POST too large

[StreetYo]

No duplicates 🥲.

• I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

Hi everyone!
When I'm trying to send more than 8M POST data, I'm getting 500 error with message:

POST too large

Use https://github.com/StreetYo/rr-post-error to reproduce the error.

1. rr.exe serve
2. php test.php

Version

php: 8.1
rr.exe version 2.9.4

Relevant log output

# rr.exe serve
[INFO] RoadRunner server started; version: 2.9.4, buildtime: 2022-05-06T16:59:44+0000
2022-06-14T01:52:51.347+0500    DEBUG   server          worker is allocated     {"pid": 18088, "internal_event_name": "EventWorkerConstruct"}
2022-06-14T01:52:51.349+0500    DEBUG   http            http server was started {"address": "0.0.0.0:8080"}
2022-06-14T01:52:58.090+0500    ERROR   http            request forming error   {"start": "2022-06-14T01:52:58.018+0500", "elapsed": "71.2208ms", "error": "http: POST too large"}

[7krasov-casafari]

Hi,
I've got the same problem
I tried without max_request_size, with 0, and with 256 but was unable to pass 12M POST data (it takes 12M if put to the file, but I don't send it as a file)
PHP ini settings are available to accept such size:

command: "php -d memory_limit=192M -d post_max_size=100M /var/app/worker/worker.php"

A request is:
curl -v -X POST http://0.0.0.0:8082/test -H "Content-Type: application/x-www-form-urlencoded" -d @post.txt

It is tested wit both 2.8.8 and 2.10.4

[rustatian]

Hey 👋🏻 Thanks for the report, I'll try to reproduce the bug, and in case of success, I will fix it in the 2.10.5 (next bugfix release 23.06).

[rustatian]

Ok guys, this issue is confirmed. The current limit for the x-www-form-urlencoded is 10MB, and I will sync it with the max_request_size limit.

[rustatian]

Notes (@rustatian): Use the MaxBytesReader here: https://github.com/roadrunner-server/http/blob/master/handler/request.go#L94

r.Body = http.MaxBytesReader(w, r.Body, MaxFileSize) 
r.ParseForm()