[🐛 BUG]: Failed logging by file_logger_options hide permission error

[Kaspiman]

No duplicates 🥲.

• I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

Maybe bug, i'm not sure

Version (rr --version)

rr version 2023.2.0 (build time: 2023-07-06T19:02:11+0000, go1.20.5), OS: linux, arch: amd64

How to reproduce the issue?

Let's say we have application in Docker container with volume for dev purpose. Log file permissions can be changed due to volume synchronization: uid:guid inside and outside has different values.

docker-compose fragment:

services:
    php:
        volumes:
            - ./:/app

RR logs fragment:

logs:
    mode: raw
    level: debug
    output: stderr
    file_logger_options:
        log_output: rr.log

The file rr.log will be created, but the owner will be changed almost immediately. Nothing will be written to the file, nor will it be written to the output. Silence.

Previous logging settings are ignored if file_logger_options are specified.

Maybe there should be fallback to stdout or mixed logging with the previously specified parameters (output, level, mode): zapcore.NewMultiWriteSyncer(zapcore.AddSync(os.Stdout), w)

Relevant log output

No response

[Kaspiman]

There another "bug" with log. If I delete a file it won't be created automatically natefinch/lumberjack#52

[rustatian]

Hey @Kaspiman 👋🏻
Thanks for the report 👍🏻

[Kaspiman]

@rustatian I found another problem with lamberjack library. Default file permission 600 is too strict, we can't easy read logs by filebeat. natefinch/lumberjack#168 after this MR we can change permission to 644. At this moment, the file_logger_options functionality is not ready for production use.

The package looks abandoned natefinch/lumberjack#170

@rustatian I have another question: is it possible to reliably rotate files with config:

logs:
   output: rr.log

During rotation, a file can be deleted and re-created. Will the logs disappear at this time?

[rustatian]

I found another problem with lamberjack library

This package is quite small. I may fork it, add it to the RR organization, and continue to maintain it.

I have another question: is it possible to reliably rotate files with config:

Should be possible, but you have to track the file size by yourself.

[Kaspiman]

@rustatian It would be nice to maintain that project. I can share information about the new fork among users of the old library. This will help attract more attention to Roadrunner

[rustatian]

@Kaspiman Done: https://github.com/roadrunner-server/filelogger
I'll spruce it up a bit, update go.mod, etc. Then it would be able to move unmerged PR's here.

[rustatian]

Oh my, there are a lot of races in this package...

[Kaspiman]

A journey of a thousand miles begins with a single step

[rustatian]

I've decided to move towards the official log/slog link package and deprecate/remove logger from Uber.
This would be a wholly new filelogger package. As the result, this bug is no more actual.