Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request/Response communication over binary protocol #40

Closed
wolfy-j opened this issue Sep 30, 2018 · 1 comment
Closed

Request/Response communication over binary protocol #40

wolfy-j opened this issue Sep 30, 2018 · 1 comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Comments

@wolfy-j
Copy link
Contributor

wolfy-j commented Sep 30, 2018

Currently, Response status code and headers being passed using json. Switching to raw binary exchange (pack/byte reader) makes response unmarshalling 2-4 times faster.
@wolfy-j wolfy-j added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. help wanted labels Sep 30, 2018
@wolfy-j wolfy-j changed the title Performance: Response communication over binary protocol Response communication over binary protocol Sep 30, 2018
@wolfy-j
Copy link
Contributor Author

wolfy-j commented Sep 30, 2018 •
edited

Similar approach must be used for static Request fields, but ParsedBody must remain in JSON form (possibly with faster JSON encoder).

Estimated performance improvement after both changes: +6%

@wolfy-j wolfy-j changed the title Response communication over binary protocol Request/Response communication over binary protocol Oct 5, 2018
@wolfy-j wolfy-j closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wolfy-j