New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to EDF.jl #91
Comments
Or fork and maintain BDF.jl, but that's less than ideal |
FYI since you linked the PR, EDF.jl v0.6.3 supports reading and writing BDF files 🙂 |
That's amazing! Thanks so much for your hard work @ararslan. I will switch to your package when I have a spare few hours. I appreciate your contribution greatly! |
I played with this a few weeks ago and imported data with no issue, however, I was unable to extract annotation information. This seems to have been because I was reading old documentation, but is now fixed in beacon-biosignals/EDF.jl#52. So I should try and extract annotation information again. Once this is working I would like to refactor the BDF reading code as there is lots of code repetition. And I would like to make the read functions more agnostic of the datatype being read. |
If I understand correctly, it seems that the |
Oh no. That's bad news. We need the status channel for BDF. What about for BDF+? Does EDF.jl correctly extract triggers for BDF+ files? |
The |
Thanks for the summary @likanzhan! So I will continue with my plan to refactor the current reading code to be less BDF specific (remove hard coding of parameters, remove repeated code, modularise tasks). Then we can add I will report back here when its done. But feel free to try and tackle it in the meantime (its just that part of the code is pretty BDF specific, sorry) |
@likanzhan, can you open an issue on EDF.jl with some details about the status channel not working? Without supporting that, BDF support is technically incomplete, so I'll see if I can get that fixed. I don't have access to any BDF files with a status channel though. |
Hi @rob-luke, The branch beacon-biosignals/EDF.jl#61 (not released yet) can now handle the |
Apologies, I've not been able to get back to that PR for a while. One question I have for the folks who would be using it is what behavior would be desirable for calling |
The current reader used is https://github.com/sam81/BDF.jl which hasn't been updated since 2018, this is only an issue as it is requiring old package dependencies.
Best plan seems to be to switch over to beacon-biosignals/EDF.jl#46 once its merged.
The text was updated successfully, but these errors were encountered: