Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason why mergeTags is required? #56

Open
claeusdev opened this issue Jul 19, 2022 · 3 comments
Open

Is there a reason why mergeTags is required? #56

claeusdev opened this issue Jul 19, 2022 · 3 comments

Comments

@claeusdev
Copy link

I am trying to test this out for a use case, I don't think I would need mergeTags props as a functionality. If you could advise on how to get around it or the reason why it's a required prop.

@dstpierre
Copy link
Collaborator

@claeusdev good question. In fact there's no reason at all why the mergeTags property is required.

I've done a quick look at the code and it seems it might be turned optional, specifically line:125 should work for null property.

Since you mention wanting to check at #53 feel free to add this property optional in a separate PR please and if you have a chance to test it out when not specifying a value that all is good, that'd be great.

@claeusdev
Copy link
Author

Alright, sounds great. Also, I realized some tooling would be helpful for contributors. ie. my current setup is set to format on save, upon trying to open a PR, I realized that some formatting has changed? Do we keep on with this or do you think it would be great to have some basic config setup?

@dstpierre
Copy link
Collaborator

@claeusdev might be a good option yes, would prevent from having changes that do not relate to a PR but are just formatting.

What are you using? Do you have a suggestion (I'm mainly doing Go since 2014, formatting is built into the tooling). Not doing much JS/TS lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants