Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve telnet handling #2

Open
rob05c opened this issue Aug 30, 2013 · 0 comments
Open

improve telnet handling #2

rob05c opened this issue Aug 30, 2013 · 0 comments

Comments

@rob05c
Copy link
Owner

rob05c commented Aug 30, 2013

Currently, telnet commands are sent when 3 codes are received. This is insufficient and brittle.

Listeners should forward all telnet command codes to a telnet manager for that connection. The manager should buffer command bytes until a complete command is received, or a new IAC is received.

The telnet manager should also be able to take over listening to handle advanced telnet options which involve messages without the command bit set. Alternatively, the telnet manager could be able to request non-command bytes.

Due to concurrency, the listener may process necessary non-command bytes before it receives the divert message from the telnet manager. Because of this, the manager may not be able to run concurrently with the listener.

Messages sent to clients must also go through a telnet handler. E.g. compression, encryption.

@rob05c rob05c closed this as completed Aug 30, 2013
@rob05c rob05c reopened this Aug 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant