Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider requiring C++14 #58

Closed
musicinmybrain opened this issue Jan 29, 2023 · 1 comment · Fixed by #59
Closed

Consider requiring C++14 #58

musicinmybrain opened this issue Jan 29, 2023 · 1 comment · Fixed by #59

Comments

@musicinmybrain
Copy link

Since version 1.13.0, GoogleTest requires at least C++14. I think (but don’t have a very handy way to verify) that the minimum GCC version for this library,

* gcc (v6.3.0 and above)

should support C++14, so maybe it’s time to just make that the requirement by adjusting

set(CMAKE_CXX_STANDARD 11)

to C++14 instead of C++11.

What do you think?

@junghans
Copy link
Contributor

I made #59, which forces C++11 only on the target, so one can then overwrite CMAKE_CXX_STANDARD however needed.

Moving to C++14 would be a good idea additionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants