Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package needs to implement Google's new "allow" attribute #22

Closed
SamMeeDee opened this issue Apr 29, 2018 · 2 comments
Closed

Package needs to implement Google's new "allow" attribute #22

SamMeeDee opened this issue Apr 29, 2018 · 2 comments

Comments

@SamMeeDee
Copy link

Google has recently deprecated permissions for access to user devices in cross-origin iframes. Please review this article: https://dev.chromium.org/Home/chromium-security/deprecating-permissions-in-cross-origin-iframes#TOC-To-continue-to-use-permissions-from-iframes-on-your-website...

I have attempted to fork the project and add the attribute myself, compile it, and then reinstall the package from my GitHub instead of from NPM. But when I try to load it into an application I am working on and compile the app, it throws 50 errors to the browser console, like the code has not been transpiled. The only way I can get this package to work is to use the official one from NPM (which doesn't include "allow").

I can hack around this for this app (its a class project). But for future, would probably be a good idea to implement this attribute, if only for cross-browser support.

@robbestad
Copy link
Owner

Looking into it now :)

@robbestad
Copy link
Owner

Support added with react-iframe@1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants