Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaLumberjack Subproject #50

Closed
wants to merge 2 commits into from
Closed

CocoaLumberjack Subproject #50

wants to merge 2 commits into from

Conversation

Tricertops
Copy link

I removed all CocoaLumberjack files directly included in repo in Vendor/CocoaLumberjack and added them as subrepository CocoaLumberjack to the same directory.

It now contains the latest changes including dispach_get_current_queue deprecation warning fix.

@lupinglade
Copy link

It would be nice to get rid of this dependency altogether IMHO, at least it should be optional.

@siuying
Copy link

siuying commented Mar 5, 2013

It would be great to merge this in.

@vronin
Copy link
Collaborator

vronin commented Mar 6, 2013

I updated CocoaLumberjack with the latest available code.

@iMartinKiss : I am not sure that we should switch to submodules. I agree it makes thing clearer, but it pushes some work from a maintainer to a person whole clone/pull repository. It will require to do two additional commands while clone "git submodule init" and "git submodule clone". Also, it requires to do "git pull --recurse-submodules" I believe it requires a little bit more thinking (especially, since Robbie kept it like that for quite long time).

@lupinglade: Please, can you write it as separate issue? Did you mean that NSLog should be used as default?

@vronin vronin closed this Mar 6, 2013
@lupinglade
Copy link

@vronin: Yes, exactly. Sure, I will create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants