Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moment interaction diagrams should terminate at M=0 #68

Open
3 tasks
robbievanleeuwen opened this issue Nov 18, 2022 · 0 comments
Open
3 tasks

Moment interaction diagrams should terminate at M=0 #68

robbievanleeuwen opened this issue Nov 18, 2022 · 0 comments
Assignees
@robbievanleeuwen
Labels
bug Something isn't working enhancement New feature or request

Comments

@robbievanleeuwen
Copy link
Owner

robbievanleeuwen commented Nov 18, 2022 •
edited

Actions:

  • Terminate moment interaction diagrams at M=0 so that point_in_diagram() works as intended. Currently for asymmetric diagrams it is possible to have a point reported as outside the diagram when it should strictly be in the diagram (conservative). However, there should currently be no unconservative reporting.
  • Give (bring back) the option of plotting the negative diagram? (may assist with the above)
  • More efficient max_comp computation. We don't need to compute above max_comp.

See discussion here and here.

Originally posted by @Agent6-6-6 in #66 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robbievanleeuwen robbievanleeuwen

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbievanleeuwen