Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 #401

Closed
robbievanleeuwen opened this issue Mar 5, 2024 · 5 comments · Fixed by #404
Closed

Python 3.12 #401

robbievanleeuwen opened this issue Mar 5, 2024 · 5 comments · Fixed by #404
Labels
build Build System and Dependencies

Comments

@robbievanleeuwen
Copy link
Owner

Support Python 3.12!

Currently awaiting rhino3dm for full integration.

@robbievanleeuwen robbievanleeuwen added the build Build System and Dependencies label Mar 5, 2024
@dpnova
Copy link

dpnova commented Mar 8, 2024

I notice rhino3dm is an optional dep - I'll get the team to try installing/using the lib without it cc @haiderali101

edit: wait, rhino3dm is also listed in the core deps... my bad!

@robbievanleeuwen robbievanleeuwen linked a pull request Mar 9, 2024 that will close this issue
@robbievanleeuwen
Copy link
Owner Author

Hi @dpnova, rhino3dm is currently an optional dependency and will not be installed by running pip install sectionproperties. It will only be installed by running pip install sectionproperties[rhino], more info here.

@dpnova
Copy link

dpnova commented Apr 7, 2024

Hi @dpnova, rhino3dm is currently an optional dependency and will not be installed by running pip install sectionproperties. It will only be installed by running pip install sectionproperties[rhino], more info here.

Circling back to this @robbievanleeuwen - I've been out of python land a bit so I'm not super familiar with newer tools like poetry etc.

when I run the following, rhino3dm builds:

pip install sectionproperties Topologicpy

I see this in the output just before rhino3dm starts building (long build):

Collecting rhino3dm (from rhino-shapley-interop>=0.0.4->sectionproperties)
  Downloading rhino3dm-8.4.0.tar.gz (66.0 MB)

I see in the pyproject.toml for sectionproperties that the dep is an optional, when using the rhino extra in poetry.

Curiously, when i run:

pip install sectionproperties 

it doesn't start building rhino3dm, what am I missing here? :D My guess is that one of the other deps is causing an upgrade of a transitive lib, which is making sectionproperties do something very odd?

In the log I see this:

Collecting sectionproperties
  Using cached sectionproperties-3.2.0-py3-none-any.whl.metadata (6.5 kB)
  Using cached sectionproperties-2.0.3-py3-none-any.whl.metadata (12 kB)

I'm guessing you didn't have rhino3dm as optional in the older version?

@robbievanleeuwen
Copy link
Owner Author

Hi @dpnova, in previous versions of sectionproperties, rhino-shapley-interop (and thus rhino3dm) was not optional. Have you tried installing sectionproperties in a fresh virtual environment? It looks like you have some older versions cached in your environment.

If you're not contributing to the project, poetry shouldn't change anything for you - it's mainly used to manage the development dependencies and build the wheel.

@dpnova
Copy link

dpnova commented Apr 17, 2024

Thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build System and Dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants