New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins and Themes should not be stored in this git repo #1014

Closed
drubin opened this Issue Mar 14, 2012 · 4 comments

Comments

Projects
None yet
5 participants
@drubin

drubin commented Mar 14, 2012

oh-my-zsh should rather follow the model of plugins and themes are stored in separate repo's and be managed via a different method.

I have been trying to follow the issues and pull requests for bug fixes and any security issues but it is impossible to keep track of issues actually.

I assume that Robby and the other devs also are being flooded with requests for their themes to be included into the git repo.

My suggestion would be to maybe do something similar to weechat and irssi do with their plugins and themes. http://weechat.org/scripts/ and then they use something like apt-get (weeget) http://weechat.org/scripts/source/stable/weeget.py.html/ to install plugins which IMHO makes sense.

The repo method also means that users can manage and maintain their own plugins and themes which should free up a large amount of the cruft.

Just a suggestion feel free to comment and or shut it down.

@sorin-ionescu

This comment has been minimized.

Show comment
Hide comment
@sorin-ionescu

sorin-ionescu Mar 16, 2012

Contributor

See #377.

Contributor

sorin-ionescu commented Mar 16, 2012

See #377.

@drubin

This comment has been minimized.

Show comment
Hide comment
@drubin

drubin Mar 16, 2012

Guess it is a duplicate pitty your issue has been open for so long.

drubin commented Mar 16, 2012

Guess it is a duplicate pitty your issue has been open for so long.

@franciscolourenco

This comment has been minimized.

Show comment
Hide comment
@franciscolourenco

franciscolourenco Apr 22, 2012

I agree on this.

OMZ should ship only the core plus a reduced number of essencial plugins/themes which can be consistently maintained by the people in charge. This allows pull requests to be reviewed thoroughly taking care of the security issue, making it less dangerous to (auto)update OMZ.

All the other themes/plugins should be maintained by their creators in their own repositories, be collected on a central gallery (with voting/download count), and be installable with the help of a utility (pretty much like, for example: homebrew, npm, sublime package manager or adiumextras)

This would increase the fun of it, and distribute the responsibility of the code maintenance and quality by more people.
At the same time users could chose which plugins are worth of being installed and create alternative plugins for those who suck, letting them be voted/downloaded by the people who appreciate them.

This is a better model then having to issue a pull request to the main OMZ repository in order to change/modify the code of a plugin/theme, leaving the decision of merge in the hands of a reduced number of people who are not the creators of that particular plugin, possibly hurting the intent and vision of the original creator of the plugin.

franciscolourenco commented Apr 22, 2012

I agree on this.

OMZ should ship only the core plus a reduced number of essencial plugins/themes which can be consistently maintained by the people in charge. This allows pull requests to be reviewed thoroughly taking care of the security issue, making it less dangerous to (auto)update OMZ.

All the other themes/plugins should be maintained by their creators in their own repositories, be collected on a central gallery (with voting/download count), and be installable with the help of a utility (pretty much like, for example: homebrew, npm, sublime package manager or adiumextras)

This would increase the fun of it, and distribute the responsibility of the code maintenance and quality by more people.
At the same time users could chose which plugins are worth of being installed and create alternative plugins for those who suck, letting them be voted/downloaded by the people who appreciate them.

This is a better model then having to issue a pull request to the main OMZ repository in order to change/modify the code of a plugin/theme, leaving the decision of merge in the hands of a reduced number of people who are not the creators of that particular plugin, possibly hurting the intent and vision of the original creator of the plugin.

@sheerun

This comment has been minimized.

Show comment
Hide comment
@sheerun

sheerun Jan 4, 2013

Contributor

I agree with @aristidesfl

Contributor

sheerun commented Jan 4, 2013

I agree with @aristidesfl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment