Fix escaping for terminal window and tab titles #2429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes the handling of terminal window and tab titles if the command entered contains , %, $, `, or !. It handles the options PROMPT_SUBST, PROMPT_BANG, and PROMPT_PERCENT correctly.
The one remaining bug is that the command "echo !" (and similar) are incorrectly shown as "echo !", not "echo !". However, I believe that this is a ZSH bug.
It is possible that oh-my-zsh assumes that PROMPT_SUBST and PROMPT_PERCENT are set. In this case, the checks for them can be omitted, and some of the parameter expansions may be able to be combined.
Prior to this, the command a=
date %s%Nwould lead to problems, such as parse errors.