New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and improve web-search plugin #3443
Refactor and improve web-search plugin #3443
Conversation
fcd66a8
to
b5cb2c1
Compare
@ajdle @Xenopathic @alessandro-pezzato @bchretien @takac @mkolosick @varunkvv @ibnHatab @biriukov @ai81 @mmounirou @friederbluemle @peteches @Guerki @stibinator @stelim @xuhdev |
👍 . Tested on ubuntu with zsh 5.0.2. Edit: Plus this makes it so easy to search for documentation with ddg aliases or github or stackoverflow. :) |
No problem on 5.0.7 on Arch Linux. There is one thing noticeable: the yandex search is using http but others are using https. I tried yandex with https which also works. Don't know if there is a specific reason to use http in this case. |
Huh, that's weird. I never checked the search page, but the home page redirects to the http URL. |
LGTM. No issues here on 5.0.2 on Ubuntu. |
There is one more thing -- would think |
I don't know, I left it like I found it. Notice that, as it is, it's backwards compatible with previously defined aliases. That said, we could add a |
c0b53a8
to
c63e630
Compare
c63e630
to
3845500
Compare
3845500
to
02d7568
Compare
Refactor and improve web-search plugin
STATUS: ready!
This pull request implements simpler logic that enables adding more search engines in the future, while mantaining ease-of-use to define aliases.
It also implements the following very solicited features:
Fix [plugin][web-search] fix + changes #1970, fix web-search plugin: unwanted output to nohup.out #3097, fix Update web-search plugin #3183, fix update web-search to not write to nohup.out #3218, fix [web-search] Redirect output of nohup command to /dev/null #3302, fix stderr redirection in web-search plugin #3441.
Fix Plugin web-search: added Yandex search engine #1845, fix add yandex support to web-search plugin #3119.
Fix add support of CYGWIN in the web-search #2831, fix Add Cygwin support to web_search #3103.
In total, 10 issues can be closed with this PR.
Feedback is greatly appreciated.