Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve web-search plugin #3443

Merged
merged 6 commits into from Feb 10, 2015

Conversation

mcornella
Copy link
Member

STATUS: ready!


This pull request implements simpler logic that enables adding more search engines in the future, while mantaining ease-of-use to define aliases.

It also implements the following very solicited features:

In total, 10 issues can be closed with this PR.
Feedback is greatly appreciated.

@mcornella
Copy link
Member Author

@ajdle @Xenopathic @alessandro-pezzato @bchretien @takac @mkolosick @varunkvv @ibnHatab @biriukov @ai81 @mmounirou @friederbluemle @peteches @Guerki @stibinator @stelim @xuhdev
Can you guys test this out?

@varunkvv
Copy link

varunkvv commented Jan 3, 2015

👍 . Tested on ubuntu with zsh 5.0.2.

Edit: Plus this makes it so easy to search for documentation with ddg aliases or github or stackoverflow. :)

@xuhdev
Copy link
Contributor

xuhdev commented Jan 3, 2015

No problem on 5.0.7 on Arch Linux. There is one thing noticeable: the yandex search is using http but others are using https. I tried yandex with https which also works. Don't know if there is a specific reason to use http in this case.

@mcornella
Copy link
Member Author

Huh, that's weird. I never checked the search page, but the home page redirects to the http URL.
I'll make it to use https then, thanks for your feedback!

@takac
Copy link
Contributor

takac commented Jan 5, 2015

LGTM. No issues here on 5.0.2 on Ubuntu.

@xuhdev
Copy link
Contributor

xuhdev commented Jan 6, 2015

There is one more thing -- would think ddg is better to be used rather than duckduckgo? But I don't know possible conflicts.

@mcornella
Copy link
Member Author

I don't know, I left it like I found it. Notice that, as it is, it's backwards compatible with previously defined aliases. That said, we could add a ddg key and keep the duckduckgo as well, but I'd like some consensus on that before I do anything.

robbyrussell added a commit that referenced this pull request Feb 10, 2015
Refactor and improve web-search plugin
@robbyrussell robbyrussell merged commit f0bbd30 into ohmyzsh:master Feb 10, 2015
@mcornella mcornella deleted the better-web-search-plugin branch February 10, 2015 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stderr redirection in web-search plugin
5 participants