Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting of the window title under Cygwin #2739

Closed
wants to merge 1 commit into from

Conversation

ferenczy
Copy link
Contributor

Common method for setting window title using escape sequences works under Cygwin on Windows too (for example in mintty, ConEmu and even in plain cmd.exe). But Cygwin sets TERM environment variable to "cygwin" by default. Therefore I have added "cygwin" to the TERM testing condition. Tested in ConEmu, mintty and cmd.exe.

@ferenczy
Copy link
Contributor Author

If there is any reason for not accepting my pull request, could you comment it please?

@mcornella
Copy link
Member

Hi, there are lots PRs waiting to get merged. I think this is cool, but I don't have a cygwin terminal to test on nor I know anybody else that could test it. For the time being, you can also set TERM in your zshrc to one that's supported (TERM=xterm), or redefine the title function inside your zshrc.

@apjanke
Copy link
Contributor

apjanke commented Jul 3, 2015

I tested on Cygwin under Windows 7. It works. It's largely unneeded with current Cygwin versions, because MinTTY declares itself as xterm and that's the main "prompt" option installed for users now. But this makes it work in cmd.exe/regular Windows console windows too (what's known as the "plain" Cygwin prompt), and it's good to have for completeness.

👍

@ferenczy
Copy link
Contributor Author

@apjanke Not only regular Windows console, but mainly ConEmu. I think that ConEmu is used much more than MinTTY, which doesn't even support multiple tabs or searching in a buffer. MinTTY isn't very good for a real-life using. I have ConEmu running permanently with a lot of opened tabs (the most of them are Cygwin, sometimes Git-Bash, PowerShell, or even plain cmd), everything inside one window. Cygwin is designed to work with TERM environment variable set to "cygwin" under Windows console (to properly translate escape sequences for it etc.), so would be great, if oh-my-zsh supports it. ConEmu unfortunately uses the Windows console, in which it executes what you want (bash, zsh etc.), but it doesn't display Windows console window, instead it renders it itself. But from Cygwin's point of view, it's running in Windows console.

@apjanke
Copy link
Contributor

apjanke commented Sep 11, 2015

Oh, cool. I didn't know about ConEmu. Checked it out today. This looks a lot nicer than MinTTY. Thanks @ferenczy !

Tested on ConEmu on Windows 7 with Cygwin zsh. Works there too.

This looks good to merge after a rebase.

@apjanke
Copy link
Contributor

apjanke commented Nov 6, 2015

Ping... want to rebase this so we can merge?

@mcornella mcornella closed this in 00344f7 Dec 1, 2015
nunogt pushed a commit to nunogt/oh-my-zsh that referenced this pull request Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants