Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin to magically escape zsh meta-characters in git commands #2847

Merged
merged 3 commits into from Aug 19, 2019
Merged

Plugin to magically escape zsh meta-characters in git commands #2847

merged 3 commits into from Aug 19, 2019

Conversation

pho3nixf1re
Copy link
Contributor

The plugin simply autoloads git-escape-magic which is included here and
copied from https://github.com/knu/zsh-git-escape-magic .

This addresses #1115

@Konfekt
Copy link
Contributor

Konfekt commented Nov 19, 2015

Looks convenient. How about taking aliases of git into account, like g ? Could this not serve as a general escape-magic plugin ? For example zcalc also would be handier if * is auto escaped.

@Konfekt
Copy link
Contributor

Konfekt commented Nov 19, 2015

Never mind. Just found out at

http://stackoverflow.com/questions/11456403/stop-shell-wildcard-character-expansion/22945024#22945024

about alias g='noglob git'

@mcornella mcornella closed this Mar 30, 2016
@Konfekt
Copy link
Contributor

Konfekt commented Mar 30, 2016

Any comments on why this has not been merged? This is a convenient plugin for users of zsh and git that otherwise needs manual fiddling to install.

@mcornella
Copy link
Member

I thought there wasn't any more interest in this plugin.

@mcornella mcornella reopened this Mar 30, 2016
@pho3nixf1re
Copy link
Contributor Author

I am still interested in this. I have it in the custom plugins folder currently and have used it since this was opened.

@mcornella
Copy link
Member

Ok, I'll gladly merge this. Can you add a README with instructions on how to use it (for instance, that it doesn't work with git aliases) and update to the latest version of the git-escape-magic file?

@pho3nixf1re
Copy link
Contributor Author

Sure, I'll get to be by the end of the week. Thanks!

pho3nixf1re and others added 3 commits May 19, 2017 14:34
This plugin simply autoloads git-escape-magic which is included here and
copied from https://github.com/knu/zsh-git-escape-magic .
Latest version of git-escape magic now escapes the @ shortcut for HEAD.
@pho3nixf1re
Copy link
Contributor Author

pho3nixf1re commented May 19, 2017

I'm cleaning house on my old PR's. I just updated this with a README and updated the script. I have also verified that this plugin still works. If there are no other concerns it should be ready for merge now. Thanks for the insane patience on this @mcornella !

@mcornella mcornella added Area: plugin Issue or PR related to a plugin New: plugin Request for a plugin or Pull Request that adds one labels Mar 24, 2019
@pho3nixf1re
Copy link
Contributor Author

Just pinging on this, I'm still using it myself and I'm sure others would like to have access to it. Anything left to get it merged?

@mcornella mcornella merged commit 8634d95 into ohmyzsh:master Aug 19, 2019
@mcornella
Copy link
Member

Congratulations on being probably the oldest PR merged (sorry)

@pho3nixf1re pho3nixf1re deleted the git-escape-magic branch August 19, 2019 16:20
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Aug 20, 2019
* upstream/master: (23 commits)
  af-magic: add hg prompt and tweak virtualenv info (ohmyzsh#8056)
  lib: delete LC_CTYPE locale setting which causes problems
  fabric: support fabric 2+ completion (ohmyzsh#8010)
  Add git-escape-magic plugin (ohmyzsh#2847)
  Add alias-finder plugin (ohmyzsh#7768)
  Allow plugins sudo and thefuck to be loaded before vi-mode (ohmyzsh#8087)
  meta: add DEBUG_ACTIONS flag to PR triage action
  git-auto-fetch: override zle-line-init only if it exists
  meta: move if condition on workflow to steps
  meta: convert workflow file to GitHub Actions v2 yml syntax
  n98-magerun: support magerun for Magento 2 (ohmyzsh#7950)
  Revert "agnoster: fix VIRTUAL_ENV_DISABLE_PROMPT logic (ohmyzsh#8050)" (ohmyzsh#8061)
  Add README file
  frontend-search: add duckduckgo as an option for fallback search (ohmyzsh#7973)
  agnoster: fix VIRTUAL_ENV_DISABLE_PROMPT logic (ohmyzsh#8050)
  common-aliases: add README (ohmyzsh#8039)
  Removing plugin that was named after an external tool, which carries a history as a racist phrase. Was reported by a user of OMZ who shared some background on the terminology and how it made them feel. (ohmyzsh#8027)
  af-magic: make separator window-size-aware (ohmyzsh#7739)
  readme: document oneliner unattended installation command (ohmyzsh#7983)
  git: add missing grev alias to README (ohmyzsh#7984)
  ...
lewg pushed a commit to lewg/oh-my-zsh that referenced this pull request Nov 25, 2019
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
lparam pushed a commit to lparam/oh-my-zsh that referenced this pull request Jul 27, 2020
crdant referenced this pull request in crdant/oh-my-zsh-custom Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin New: plugin Request for a plugin or Pull Request that adds one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants