Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Fuck plugin (https://github.com/nvbn/thefuck) #4170

Merged
merged 9 commits into from Aug 30, 2015

Conversation

black-roland
Copy link
Contributor

The Fuck plugin — magnificent app which corrects your previous console command.

Press ESC twice to correct previous console command.

@apjanke
Copy link
Contributor

apjanke commented Jul 19, 2015

Dupe of/conflicts with #3861.

@black-roland, @cristim, can you and other users of this come to a consensus on which to use?

@apjanke
Copy link
Contributor

apjanke commented Jul 19, 2015

@robbyrussell et al, is there an OMZ policy on things named "fuck" and the like? Previous PR #2555 requesting a "fuck" alias was withdrawn, but no comments on why.

@apjanke
Copy link
Contributor

apjanke commented Jul 19, 2015

Note that the Esc-Esc key binding conflicts with the sudo plugin, which binds it to adding sudo to previous command. Introduced in #1947.

@black-roland
Copy link
Contributor Author

Dupe of/conflicts with #3861.

I think these plugins can be combined into one. If @cristim agree, I will add his changes into my plugin.

@black-roland
Copy link
Contributor Author

Note that the Esc-Esc key binding conflicts with the sudo plugin, which binds it to adding sudo to previous command. Introduced in #1947.

The Fuck can partially replace sudo plugin. The Fuck can prefix with sudo commands like apt-get, yum, etc.

@robbyrussell
Copy link
Member

I don't have a fucking problem with the usage of the word fuck.

@apjanke
Copy link
Contributor

apjanke commented Jul 19, 2015

Cool. I think that note in the README is sufficient to address the binding conflict then.

@black-roland
Copy link
Contributor Author

Combined with plugin by @cristim. Also fixed compability with latest The Fuck version.

@cristim
Copy link
Contributor

cristim commented Jul 27, 2015

Looks good to me.

eval "$(thefuck-alias)"

fuck-command-line() {
FUCK="$(THEFUCK_REQUIRE_CONFIRMATION=0 thefuck $(fc -ln -1 | tail -n 1) 2> /dev/null)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this $FUCK be made local? Or is it intended to stick around for reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this $FUCK be made local? Or is it intended to stick around for reference?

Ooops. It's a bug. Added local.

@apjanke
Copy link
Contributor

apjanke commented Jul 27, 2015

Looks good to me too. Tested on OS X 10.9.5.

@robbyrussell robbyrussell added the Area: plugin Issue or PR related to a plugin label Aug 30, 2015
robbyrussell added a commit that referenced this pull request Aug 30, 2015
@robbyrussell robbyrussell merged commit a7aed69 into ohmyzsh:master Aug 30, 2015
nunogt pushed a commit to nunogt/oh-my-zsh that referenced this pull request Jan 25, 2016
@mcornella mcornella mentioned this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants