Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the readme in accordance with PR #4617 #4618

Closed
wants to merge 1 commit into from
Closed

Update the readme in accordance with PR #4617 #4618

wants to merge 1 commit into from

Conversation

ahmadawais
Copy link
Contributor

Reflecting the changes in PR #4617 in the ReadMe.

@apjanke
Copy link
Contributor

apjanke commented Nov 16, 2015

Since these doco changes should be tied to the alias changes, they could just go in the same PR. Even after you've already made a PR, you can revise it by making additional commits the the branch you based it on, or even doing git commit --amend to change the original commit, and then pushing that branch up to GitHub again.

@ahmadawais
Copy link
Contributor Author

@apjanke I have found after working in repos with multiple contributors that all pull requests must be made on a per file basis to avoid any issues.

Let me know if you'd like me to revise it.

@ahmadawais
Copy link
Contributor Author

@apjanke I have update the PR #4617 as per your comment. Kindly merge it.

@ahmadawais ahmadawais closed this Nov 17, 2015
@ahmadawais ahmadawais deleted the patch-2 branch November 17, 2015 07:25
@apjanke
Copy link
Contributor

apjanke commented Nov 17, 2015

Thanks.

I'm not one of the repo owners; so I can't merge it myself. That will need to wait for robbyrussell or mcornella to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants