Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of loadable modules #5219

Closed
wants to merge 1 commit into from
Closed

better handling of loadable modules #5219

wants to merge 1 commit into from

Conversation

rockdrilla
Copy link

prevent loading specific modules (oh-my-zsh/lib/*.zsh) via "config_exclude" variable instead of messing with .gitignore

@apjanke
Copy link
Contributor

apjanke commented Jul 13, 2016

What's the motivation for this? OMZ expects all files from lib to always be loaded, and other OMZ code is written under that assumption.

@rockdrilla
Copy link
Author

I think it's better provide more elegant way to exclude some files than hard way to git-ignore them. Also, I've inspected OMZ/lib/ and not found any tight dependencies. May I ask you to point such cases?

@apjanke
Copy link
Contributor

apjanke commented Jul 16, 2016

I think it's better provide more elegant way to exclude some files than hard way to git-ignore them.

But why do you want to do this in the first place?

Also, I've inspected OMZ/lib/ and not found any tight dependencies. May I ask you to point such cases?

The dependencies are from plugins and themes, which may use stuff defined in lib/ files. E.g. the frisk theme uses bzr_prompt_info, the common-aliases plugin uses is-at-least, which is autoloaded by lib/misc.zsh and lib/diagnostics.zsh, various plugins use open_command from lib/functions.zsh, and so on.

@rockdrilla
Copy link
Author

rockdrilla commented Aug 15, 2016

But why do you want to do this in the first place?
The dependencies are from plugins and themes, which may use stuff defined in lib/ files.

My motivation is to provide clean way to exclude modules from loading if end-user wants it to. Customization is the corner stone of OMZ, and why we force end-user to mess with git-ignore instead of modifying config parameter? End-user must have choice to enable/disable modules without carrying on OMZ code base integrity.
PS: as usual, i'm sorry about my poor english.

prevent loading specific modules (oh-my-zsh/lib/*.zsh)
via "config_exclude" variable
instead of messing with .gitignore
@mcornella mcornella added Feature New feature or request Area: core Issue or PR related to core parts of the project Resolution: wontfix This will not be worked on labels Oct 13, 2016
@mcornella
Copy link
Member

This is a feature that we won't implement anytime soon. If we did, the project would end up being a giant Frankenstein monster of things users want to ignore. Hopefully we can fix any issues you're having with lib files in a different way.

@rockdrilla
Copy link
Author

Closing PR. So long, and thanks for all the fish.

@rockdrilla rockdrilla closed this Mar 7, 2018
@rockdrilla rockdrilla deleted the krd-better-handling-submodules branch March 7, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Feature New feature or request Resolution: wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants