Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use https everywhere #6574

Merged
merged 2 commits into from Aug 7, 2018
Merged

use https everywhere #6574

merged 2 commits into from Aug 7, 2018

Conversation

YoshiMan
Copy link
Contributor

No description provided.

@ojongerius
Copy link

Nice work! Did you verify those urls support https too?

@YoshiMan
Copy link
Contributor Author

I have looked for http urls with the following command.
grep -R http:// oh-my-zsh/plugins/ --include='*.zsh
Then I changed the http to https and checked the url with the browser.
There have been some cases

  • no response even on the http version -> I changed nothing
  • no response -> I changed nothing
  • invalid certificate -> I changed nothing
  • mixed content -> I changed to https
  • everything ok -> I changed to https

@YoshiMan
Copy link
Contributor Author

Hey @ojongerius,
did you read my response? What do you think about my pull request?
I wrote an email to the guy who has the website with the mixed content. :)

@ojongerius
Copy link

@YoshiMan I did, thanks for going the extra mile!

I don't have write permissions to this repository, so not the person to convince this is a good thing. Just trying to chime in and make sure this PR is good to merge when a collaborator or owner comes along and has a look.

@YoshiMan
Copy link
Contributor Author

Ah okay. Thanks a lot.
I hope this pullrequest wont be dead like #6484 and #6485

@ojongerius
Copy link

Same! Seems like there is more work than hands in regards to code review and merges.

YoshiMan and others added 2 commits August 7, 2018 18:42
@YoshiMan @mcornella
use https everywhere
17df2c4
@mcornella
use https links on the files that are left
02decf0 
Also, removed some broken links and updated redirections.
@mcornella
Copy link
Member

I've updated the PR with the rest of http links that could be changed and got rid of broken links in the process. This is now ready to merge. Thanks for getting the ball rolling!

Just a few days after the Chrome change! :)

@mcornella mcornella merged commit 19b925e into ohmyzsh:master Aug 7, 2018
@YoshiMan YoshiMan deleted the useHttpsForLinks branch August 7, 2018 19:46
@YoshiMan
Copy link
Contributor Author

YoshiMan commented Aug 7, 2018

Yeah thank you 👍

bjornreppen pushed a commit to bjornreppen/oh-my-zsh that referenced this pull request Aug 11, 2018
@YoshiMan @bjornreppen
use https everywhere (ohmyzsh#6574)
bbd1da5 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
lellisls pushed a commit to lellisls/oh-my-zsh that referenced this pull request Oct 1, 2018
@YoshiMan @lellisls
use https everywhere (ohmyzsh#6574)
31e70ef 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
@YoshiMan
use https everywhere (ohmyzsh#6574)
62fb353 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
@YoshiMan @jmartindf
use https everywhere (ohmyzsh#6574)
e769888 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
sagischwarz pushed a commit to sagischwarz/ohmyzsh that referenced this pull request Nov 19, 2018
@YoshiMan @mcornella
use https everywhere (ohmyzsh#6574)
b7474a2 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
chihchun pushed a commit to chihchun/oh-my-zsh that referenced this pull request Aug 6, 2019
@YoshiMan @chihchun
use https everywhere (ohmyzsh#6574)
3c52212 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
kankongmeng pushed a commit to kankongmeng/oh-my-zsh that referenced this pull request Jan 8, 2020
@YoshiMan
use https everywhere (ohmyzsh#6574)
e47b3b1 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
@YoshiMan @spiliopoulos
use https everywhere (ohmyzsh#6574)
04a84fc 
* use https everywhere

* use https links on the files that are left

Also, removed some broken links and updated redirections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YoshiMan @ojongerius @mcornella