fix: error passing context to jinja hook calls

tackle/models.py

@@ -448,12 +448,6 @@ class LazyBaseFunction(BaseModel):
         description="List of fields used to 1, enrich functions without exec method, "
         "and 2, inherit base attributes into methods. Basically a helper.",
     )
-    function_methods: list = Field(
-        None,
-        description="List of methods so that when we use a function as a jinja hook, "
-        "we can easily enrich them without having to iterate over all of "
-        "its fields to detect if it is a callable.",
-    )
 
 
 class JinjaHook(BaseModel):
@@ -478,7 +472,20 @@ def wrapped_exec(self, *args, **kwargs):
         evaluate_args(
             args=args_list, hook_dict=kwargs, Hook=self.hook, context=self.context
         )
-        output = self.hook(**kwargs, **self.context.dict()).exec()
+        # Can't simply do self.hook(**kwargs, **self.context.dict()) because the
+        #  references might not be copied over properly.
+        output = self.hook(
+            **kwargs,
+            input_context=self.context.input_context,
+            public_context=self.context.public_context,
+            existing_context=self.context.existing_context,
+            no_input=self.context.no_input,
+            calling_directory=self.context.calling_directory,
+            calling_file=self.context.calling_file,
+            provider_hooks=self.context.provider_hooks,
+            key_path=self.context.key_path,
+            verbose=self.context.verbose,
+        ).exec()
         return output
 
     def set_method(self, key: str, method: Callable):

tackle/parser.py

@@ -956,7 +956,7 @@ def create_function_model(
     )
 
     # fmt: on
-    new_func = {'hook_type': func_name, 'function_fields': [], 'function_methods': []}
+    new_func = {'hook_type': func_name, 'function_fields': []}
     literals = ('str', 'int', 'float', 'bool', 'dict', 'list')  # strings to match
     # Create function fields from anything left over in the function dict
     for k, v in func_dict.items():

tests/models/test_models.py

@@ -3,8 +3,10 @@
 import sys
 
 from tackle.models import (
+    BaseContext,
     BaseHook,
     Context,
+    JinjaHook,
 )
 
 
@@ -69,8 +71,22 @@ def test_models_latest():
     assert c.checkout == 'latest'
 
 
+# TODO: RM
 def test_models_lazy_base_function():
     from tackle.models import LazyBaseFunction
 
     c = LazyBaseFunction(function_dict={}, function_fields=[], hook_type="foo")
     assert c
+
+
+def test_models_jinja_hook():
+    """
+    Test that wrapped_exec properly passes references to context vars such as
+     public_context between a hook call.
+    """
+    context = BaseContext()
+    context.provider_hooks = Context().provider_hooks
+    c = JinjaHook(context=context, hook=context.provider_hooks['set'])
+    c.context.public_context = {}
+    c.wrapped_exec(path="foo", value=1)
+    assert c.context.public_context == {"foo": 1}