Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assigning duplicate base fields #104

Closed
robcxyz opened this issue Nov 14, 2022 · 1 comment
Closed

Allow assigning duplicate base fields #104

robcxyz opened this issue Nov 14, 2022 · 1 comment

Comments

@robcxyz
Copy link
Collaborator

robcxyz commented Nov 14, 2022

Calling this:

local->: tackle args.yaml --no_input

Raises type error here:

            try:
                hook = Hook(
                    **hook_dict,
                    input_context=context.input_context,
                    public_context=context.public_context,
                    private_context=context.private_context,

Added

            tmp_no_input = None if 'no_input' not in hook_dict else hook_dict.pop('no_input')
# and 
                    no_input=context.no_input if tmp_no_input is None else tmp_no_input,

But this is hacky. Should be managed through composition which will reduce conflicts.

@robcxyz
Copy link
Collaborator Author

robcxyz commented Oct 28, 2023

Fixed in 0.6.x

@robcxyz robcxyz closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant